Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation/testing issues against numpy 2.0 #401

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

phargogh
Copy link
Member

This PR fixes an issue with our build dependencies. We used to have to use oldest-supported-numpy when building to ensure compatibility with older versions of numpy. It now appears that building against numpy>=2 is sufficient for allowing pygeoprocessing to run against earlier versions of numpy.

The only catch appears to be that numpy 2 was only released for python>=3.9, so we are still building against oldest-supported-numpy for python 3.8 builds.

Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phargogh!

@emlys emlys merged commit 1cb674c into natcap:main Jun 28, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants